Fix FlatMapRestAction predicate with complete or submit #2636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinnDevelopment
requested changes
Mar 30, 2024
src/main/java/net/dv8tion/jda/internal/requests/restaction/operator/FlatMapRestAction.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/requests/restaction/operator/FlatMapRestAction.java
Outdated
Show resolved
Hide resolved
src/main/java/net/dv8tion/jda/internal/requests/restaction/operator/FlatMapRestAction.java
Outdated
Show resolved
Hide resolved
…rator/FlatMapRestAction.java Co-authored-by: Florian Spieß <business@minn.dev>
mergify bot
referenced
this pull request
in SvenKirschbaum/musikbot-client
Apr 6, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | maven | stage | digest | `2b884f2` -> `3a69a5d` | | | | | | rust | stage | patch | `1.77.0-bookworm` -> `1.77.1-bookworm` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [net.dv8tion:JDA](https://togithub.com/DV8FromTheWorld/JDA) | compile | patch | `5.0.0-beta.21` -> `5.0.0-beta.22` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DV8FromTheWorld/JDA (net.dv8tion:JDA)</summary> ### [`v5.0.0-beta.22`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.0-beta.22): | Bulk ban, premium apps, bug fixes ### Overview This release adds some newer API features, like premium app subscriptions, bot banners, and bulk banning users. Besides new features, this release also includes improved errors and bug fixes. ##### Premium App Subscriptions ([#​2583](https://togithub.com/DV8FromTheWorld/JDA/issues/2583)) If your bot is eligible for monetization, you can now use JDA to handle [**entitlements**](https://docs.jda.wiki/net/dv8tion/jda/api/interactions/Interaction.html#getEntitlements\(\)) in interactions to restrict features. With [`event.replyWithPremiumRequired()`](https://docs.jda.wiki/net/dv8tion/jda/api/interactions/callbacks/IPremiumRequiredReplyCallback.html#replyWithPremiumRequired\(\)), you can upsell a premium subscription to a user:  Read more about entitlements and premium app subscriptions in the [Discord Developer Docs](https://discord.com/developers/docs/monetization/app-subscriptions). ##### Bulk Ban ([#​2630](https://togithub.com/DV8FromTheWorld/JDA/issues/2630)) You can now ban up to 200 users in one request using [`guild.ban(users, messageDeleteTimeframe)`](https://docs.jda.wiki/net/dv8tion/jda/api/entities/Guild.html#ban\(java.util.Collection,java.time.Duration\)). This endpoint has a few quirks to keep in mind: - The [BulkBanResponse](https://docs.jda.wiki/net/dv8tion/jda/api/entities/BulkBanResponse.html) includes **failed users** and **banned users** - If a user was already banned, they are in the **failed users** - If you don't have permissions to ban a user (higher role / owner), they also appear in **failed users** - The self user also appears in **failed users** - If all users "failed" you get an error response instead #### New Features - Add support for bulk banning users by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2630](https://togithub.com/discord-jda/JDA/pull/2630) - Add the ability to set the bot banner by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2629](https://togithub.com/discord-jda/JDA/pull/2629) - Add support for premium app subscriptions by [@​Giuliopime](https://togithub.com/Giuliopime) in [https://github.com/discord-jda/JDA/pull/2583](https://togithub.com/discord-jda/JDA/pull/2583) #### Changes - Create an exception when receiving UNKNOWN_WEBHOOK in interaction hooks by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2621](https://togithub.com/discord-jda/JDA/pull/2621) #### Bug Fixes - Fix format specifiers when adding invalid choices by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2628](https://togithub.com/discord-jda/JDA/pull/2628) - Fix FlatMapRestAction predicate with complete or submit by [@​Whizyyy](https://togithub.com/Whizyyy) in [https://github.com/discord-jda/JDA/pull/2636](https://togithub.com/discord-jda/JDA/pull/2636) - Handle numeric keys for ETF maps by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2642](https://togithub.com/discord-jda/JDA/pull/2642) **Full Changelog**: discord-jda/JDA@v5.0.0-beta.21...v5.0.0-beta.22 ### Installation #### Gradle ```gradle repositories { mavenCentral() } dependencies { implementation("net.dv8tion:JDA:5.0.0-beta.22") } ``` #### Maven ```xml <dependency> <groupId>net.dv8tion</groupId> <artifactId>JDA</artifactId> <version>5.0.0-beta.22</version> </dependency> ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on sunday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/SvenKirschbaum/musikbot-client).
BachErik
referenced
this pull request
in BachErik/Hypixel-Stats-generator
Apr 7, 2024
](https://renovatebot.com){kind=link}
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [net.dv8tion:JDA](https://togithub.com/DV8FromTheWorld/JDA) | `5.0.0-beta.21` -> `5.0.0-beta.22` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>DV8FromTheWorld/JDA (net.dv8tion:JDA)</summary> ### [`v5.0.0-beta.22`](https://togithub.com/discord-jda/JDA/releases/tag/v5.0.0-beta.22): | Bulk ban, premium apps, bug fixes ### Overview This release adds some newer API features, like premium app subscriptions, bot banners, and bulk banning users. Besides new features, this release also includes improved errors and bug fixes. ##### Premium App Subscriptions ([#​2583](https://togithub.com/DV8FromTheWorld/JDA/issues/2583)) If your bot is eligible for monetization, you can now use JDA to handle [**entitlements**](https://docs.jda.wiki/net/dv8tion/jda/api/interactions/Interaction.html#getEntitlements\(\)) in interactions to restrict features. With [`event.replyWithPremiumRequired()`](https://docs.jda.wiki/net/dv8tion/jda/api/interactions/callbacks/IPremiumRequiredReplyCallback.html#replyWithPremiumRequired\(\)), you can upsell a premium subscription to a user:  Read more about entitlements and premium app subscriptions in the [Discord Developer Docs](https://discord.com/developers/docs/monetization/app-subscriptions). ##### Bulk Ban ([#​2630](https://togithub.com/DV8FromTheWorld/JDA/issues/2630)) You can now ban up to 200 users in one request using [`guild.ban(users, messageDeleteTimeframe)`](https://docs.jda.wiki/net/dv8tion/jda/api/entities/Guild.html#ban\(java.util.Collection,java.time.Duration\)). This endpoint has a few quirks to keep in mind: - The [BulkBanResponse](https://docs.jda.wiki/net/dv8tion/jda/api/entities/BulkBanResponse.html) includes **failed users** and **banned users** - If a user was already banned, they are in the **failed users** - If you don't have permissions to ban a user (higher role / owner), they also appear in **failed users** - The self user also appears in **failed users** - If all users "failed" you get an error response instead #### New Features - Add support for bulk banning users by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2630](https://togithub.com/discord-jda/JDA/pull/2630) - Add the ability to set the bot banner by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2629](https://togithub.com/discord-jda/JDA/pull/2629) - Add support for premium app subscriptions by [@​Giuliopime](https://togithub.com/Giuliopime) in [https://github.com/discord-jda/JDA/pull/2583](https://togithub.com/discord-jda/JDA/pull/2583) #### Changes - Create an exception when receiving UNKNOWN_WEBHOOK in interaction hooks by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2621](https://togithub.com/discord-jda/JDA/pull/2621) #### Bug Fixes - Fix format specifiers when adding invalid choices by [@​freya022](https://togithub.com/freya022) in [https://github.com/discord-jda/JDA/pull/2628](https://togithub.com/discord-jda/JDA/pull/2628) - Fix FlatMapRestAction predicate with complete or submit by [@​Whizyyy](https://togithub.com/Whizyyy) in [https://github.com/discord-jda/JDA/pull/2636](https://togithub.com/discord-jda/JDA/pull/2636) - Handle numeric keys for ETF maps by [@​MinnDevelopment](https://togithub.com/MinnDevelopment) in [https://github.com/discord-jda/JDA/pull/2642](https://togithub.com/discord-jda/JDA/pull/2642) **Full Changelog**: discord-jda/JDA@v5.0.0-beta.21...v5.0.0-beta.22 ### Installation #### Gradle ```gradle repositories { mavenCentral() } dependencies { implementation("net.dv8tion:JDA:5.0.0-beta.22") } ``` #### Maven ```xml <dependency> <groupId>net.dv8tion</groupId> <artifactId>JDA</artifactId> <version>5.0.0-beta.22</version> </dependency> ``` </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/BachErik/Hypixel-Stats-generator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Etiquette
Changes
Closes Issue: #2635
Description
This make sure the predicate of FlatMapRestAction is considered with complete or submit.