Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: mock aiohttp responses and fix windows #125

Merged
merged 5 commits into from
Nov 27, 2021

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Nov 21, 2021

fix: use WindowsSelectorEventLoopPolicy on windows

in addition, will use aioresponses for our test suite so no aiohttp sessions actually make real requests.

@codecov
Copy link

codecov bot commented Nov 21, 2021

Codecov Report

Merging #125 (8fea42f) into main (4b07917) will decrease coverage by 0.22%.
The diff coverage is 50.00%.

❗ Current head 8fea42f differs from pull request most recent head 25192c5. Consider uploading reports for the commit 25192c5 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #125      +/-   ##
==========================================
- Coverage   70.90%   70.68%   -0.23%     
==========================================
  Files          33       33              
  Lines        1619     1634      +15     
  Branches      199      202       +3     
==========================================
+ Hits         1148     1155       +7     
- Misses        439      445       +6     
- Partials       32       34       +2     
Impacted Files Coverage Δ
modmail/bot.py 37.87% <38.88%> (-0.97%) ⬇️
modmail/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6ab7918...25192c5. Read the comment docs.

@onerandomusername onerandomusername changed the title chore: fix windows dns lookup tests: mock aiohttp responses and fix windows Nov 21, 2021
@onerandomusername onerandomusername marked this pull request as draft November 21, 2021 12:19
@onerandomusername onerandomusername added a: tests Related to `unittest` tests s: needs review Ready for review and merge skip changelog Skip the need for a changelog entry for a Pull Request labels Nov 21, 2021
@onerandomusername onerandomusername marked this pull request as ready for review November 21, 2021 14:25
modmail/__init__.py Outdated Show resolved Hide resolved
@onerandomusername
Copy link
Member Author

Fixing conflicts and then merging.

@onerandomusername onerandomusername merged commit f7a3e25 into main Nov 27, 2021
@onerandomusername onerandomusername deleted the fix-aiohttp-session branch November 27, 2021 03:15
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 1509624103

  • 47 of 57 (82.46%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 78.756%

Changes Missing Coverage Covered Lines Changed/Added Lines %
tests/test_fixtures.py 18 19 94.74%
modmail/bot.py 9 18 50.0%
Totals Coverage Status
Change from base Build 1509599375: 0.2%
Covered Lines: 1672
Relevant Lines: 2123

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: tests Related to `unittest` tests s: needs review Ready for review and merge skip changelog Skip the need for a changelog entry for a Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants