Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/test error handler #94

Merged
merged 13 commits into from
Apr 21, 2022
Merged

tests/test error handler #94

merged 13 commits into from
Apr 21, 2022

Conversation

onerandomusername
Copy link
Member

@onerandomusername onerandomusername commented Oct 21, 2021

tests 99% of the error handler to ensure that all errors are handled properly and don't raise more errors.

@Shivansh-007 Shivansh-007 marked this pull request as draft October 21, 2021 05:02
@onerandomusername onerandomusername changed the base branch from main to tests/more-tests October 21, 2021 05:06
Base automatically changed from tests/more-tests to main October 28, 2021 02:47
@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #94 (6935988) into main (4b07917) will increase coverage by 6.60%.
The diff coverage is 97.95%.

❗ Current head 6935988 differs from pull request most recent head 09472f3. Consider uploading reports for the commit 09472f3 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #94      +/-   ##
==========================================
+ Coverage   70.90%   77.51%   +6.60%     
==========================================
  Files          33       33              
  Lines        1619     1739     +120     
  Branches      199      222      +23     
==========================================
+ Hits         1148     1348     +200     
+ Misses        439      357      -82     
- Partials       32       34       +2     
Impacted Files Coverage Δ
modmail/extensions/utils/error_handler.py 96.87% <95.00%> (+66.22%) ⬆️
...sts/modmail/extensions/utils/test_error_handler.py 98.74% <98.42%> (-1.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c4e1c2...09472f3. Read the comment docs.

@Shivansh-007 Shivansh-007 removed their request for review November 18, 2021 00:02
Signed-off-by: onerandomusername <genericusername414+git@gmail.com>
mock changes now mean that ctx.message.channel and ctx.channel are the same object
@onerandomusername onerandomusername marked this pull request as ready for review November 21, 2021 10:54
@onerandomusername onerandomusername added a: bot Catch all for issues regarding the bot a: tests Related to `unittest` tests p: normal Normal Priority and removed review: do not merge labels Nov 25, 2021
@onerandomusername onerandomusername added s: needs review Ready for review and merge t: enhancement Changes or improvements to existing features skip changelog Skip the need for a changelog entry for a Pull Request labels Nov 25, 2021
@coveralls
Copy link
Collaborator

coveralls commented Apr 21, 2022

Coverage Status

Coverage increased (+3.4%) to 73.349% when pulling 09472f3 on tests/test-error-handler into 0c4e1c2 on main.

@onerandomusername onerandomusername merged commit a89f5d6 into main Apr 21, 2022
@onerandomusername onerandomusername deleted the tests/test-error-handler branch April 21, 2022 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a: bot Catch all for issues regarding the bot a: tests Related to `unittest` tests p: normal Normal Priority s: needs review Ready for review and merge skip changelog Skip the need for a changelog entry for a Pull Request t: enhancement Changes or improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants