Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up code and remove duplication #94

Open
2 of 11 tasks
advaith1 opened this issue Aug 3, 2020 · 1 comment
Open
2 of 11 tasks

Clean up code and remove duplication #94

advaith1 opened this issue Aug 3, 2020 · 1 comment
Assignees
@advaith1 @carolinaisslaying
Labels
moderate priority Issue/PR is moderate priority.
Milestone
v5.7.0

Comments

@advaith1
Copy link
Member

advaith1 commented Aug 3, 2020 •
edited by carolinaisslaying
Loading

Main

  • Don't duplicate CSS across themes
  • Do checks before making Discord API request

Route-specific reused code

Check when re-used code has been moved to functions/vars for the following routes. This also includes other relevant code cleanup/refactoring.

  • authentication.ts
  • autosync.ts
  • bots.ts
  • index.ts
  • search.ts
  • servers.ts
  • staff.ts
  • templates.ts
  • users.ts
@advaith1 advaith1 added the moderate priority Issue/PR is moderate priority. label Aug 3, 2020
@advaith1 advaith1 self-assigned this Sep 6, 2020
advaith1 added a commit that referenced this issue Sep 7, 2020
@advaith1
switch to djs client.api, clean up form validation and error handling…
53a8ad3 
…, and other stuff

major backend update

closes #100
#94
@carolinaisslaying carolinaisslaying added this to the 5.5.0 milestone Apr 8, 2022
@carolinaisslaying carolinaisslaying self-assigned this Apr 9, 2022
@carolinaisslaying
Copy link
Member

4c3358c begins the improvement of code and duplication in servers.ts

@carolinaisslaying carolinaisslaying modified the milestones: 5.5.0, 6.0.0 May 26, 2022
@carolinaisslaying carolinaisslaying modified the milestones: 6.0.0, 5.6.1 Mar 20, 2024
@carolinaisslaying carolinaisslaying modified the milestones: 5.6.1, v5.7.0 May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@advaith1 advaith1

@carolinaisslaying carolinaisslaying

Labels
moderate priority Issue/PR is moderate priority.
Projects
None yet
Milestone
v5.7.0
Development

No branches or pull requests
2 participants
@advaith1 @carolinaisslaying