This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
feat:@discord.js/type-utils
package
#57
Open
suneettipirneni
wants to merge
7
commits into
discordjs:main
Choose a base branch
from
suneettipirneni:feature/typeguards
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat:@discord.js/type-utils
package
#57
suneettipirneni
wants to merge
7
commits into
discordjs:main
from
suneettipirneni:feature/typeguards
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suneettipirneni
changed the title
feat: typeguards package
feat:Aug 26, 2021
@discord.js/typeguards
package
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
==========================================
+ Coverage 85.84% 85.93% +0.09%
==========================================
Files 8 11 +3
Lines 996 1102 +106
Branches 99 113 +14
==========================================
+ Hits 855 947 +92
Misses 42 42
- Partials 99 113 +14
Continue to review full report at Codecov.
|
iCrawl
reviewed
Aug 29, 2021
So I'm leaning towards renaming this module to
Other than naming, this PR won't change anything, but I wanna keep the door open for later changes. |
Jiralite
suggested changes
Aug 29, 2021
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
suneettipirneni
changed the title
feat:
feat:Aug 29, 2021
@discord.js/typeguards
package@discord.js/type-utils
package
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Migration of discordjs/discord.js#6410 to package here.
This package offers typeguards for otherwise tedious manual typeguards. It will also eventually offer compatibility with api types and
#equals
between various types.Status and versioning classification:
Please move lines that apply to you out of the comment: