Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): make transformCommand public #6679

Closed
wants to merge 1 commit into from
Closed

fix(types): make transformCommand public #6679

wants to merge 1 commit into from

Conversation

wutv
Copy link
Contributor

@wutv wutv commented Sep 23, 2021

Please describe the changes this PR makes and why it should be merged:

Since the method is static, and can be used for more than internal code, it should be classified as public.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@monbrey
Copy link
Member

monbrey commented Sep 23, 2021

In theory, but it's not quite that simple. By making it public, we're no longer able to change or replace it in non-major version since it becomes a public-facing part of the library's interface.

@suneettipirneni
Copy link
Member

suneettipirneni commented Sep 24, 2021

This was one of the kind of things that I wanted to utilize and expose in the proposed type-utils module, however it's still not confirmed whether this will be a thing or not.

@vladfrangu
Copy link
Member

I agree with @monbrey here, might be better as a separate util package instead

@iCrawl iCrawl closed this Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants