Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types(GuildTextBasedChannel): Remove unnecessary exclusion of forum channels #9326

Merged
merged 2 commits into from
Apr 13, 2023
Merged

types(GuildTextBasedChannel): Remove unnecessary exclusion of forum channels #9326

merged 2 commits into from
Apr 13, 2023

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Apr 4, 2023

Please describe the changes this PR makes and why it should be merged:
Doesn't look like Exclude<...> does anything here.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@vercel
Copy link

vercel bot commented Apr 4, 2023

@Jiralite is attempting to deploy a commit to the discordjs Team on Vercel.

A member of the Team first needs to authorize it.

@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
discord-js-guide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 3:54pm

@Jiralite Jiralite changed the title types(GuildTextBasedChannel): Remove exclusion of forum channels types(GuildTextBasedChannel): Remove unnecessary exclusion of forum channels Apr 4, 2023
@Jiralite Jiralite added this to the discord.js 14.10 milestone Apr 4, 2023
@github-actions
Copy link

github-actions bot commented Apr 13, 2023

⚡️ Lighthouse report for the changes in this PR:

Category Score
🟢 Performance 97
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟠 PWA 70

Lighthouse ran on https://discord-js-guide-git-fork-jiralite-types-tidy-type-discordjs.vercel.app/

@kodiakhq kodiakhq bot merged commit 7ff3d52 into discordjs:main Apr 13, 2023
@Jiralite Jiralite deleted the types/tidy-type branch April 13, 2023 16:08
jaw0r3k added a commit to jaw0r3k/discord.js that referenced this pull request Apr 23, 2023
…ordjs#9326)

Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants