fix(BitField): use only enum names in iterating #9357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@jaw0r3k is attempting to deploy a commit to the discordjs Team on Vercel. A member of the Team first needs to authorize it. |
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
jaw0r3k
changed the title
vladfrangu
requested changes
Apr 9, 2023
Co-authored-by: Vlad Frangu <kingdgrizzle@gmail.com>
kyranet
approved these changes
Apr 13, 2023
|
It looks like this needs backporting, would you mind doing it? |
Sure <3 |
SpaceEEC
approved these changes
Apr 15, 2023
SpaceEEC
requested changes
Apr 15, 2023
There was a problem hiding this comment.
On a second look, this needs to be applied to other places traversing Flags too.
This only seems to be serialize (currently).
> new ActivityFlagsBitField(511).serialize()
{
'1': true,
'2': true,
'4': true,
'8': true,
'16': true,
'32': true,
'64': true,
'128': true,
'256': true,
Instance: true,
Join: true,
Spectate: true,
JoinRequest: true,
Sync: true,
Play: true,
PartyPrivacyFriends: true,
PartyPrivacyVoiceChannel: true,
Embedded: true
}
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
SpaceEEC
approved these changes
Apr 28, 2023
|
⚡️ Lighthouse report for the changes in this PR:
Lighthouse ran on https://discord-js-git-fork-jaw0r3k-patch-4-discordjs.vercel.app/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Resolves: #9350
The change may seem weird, but its working.
As enums are reverse mapped, getting keys will not only give names but values
The shown exception was permissions, but its just an object
Status and versioning classification: