This repository was archived by the owner on Jul 14, 2025. It is now read-only.
FIX: removes the need for intermediate property and updates code #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, changing the value of the reminder frequency on a user notifications page was not working. This commit also get rid of a few deprecations warning.
|
|
CvX
reviewed
Sep 30, 2020
assets/javascripts/discourse/components/remind-assigns-frequency.js.es6
Outdated
Show resolved
Hide resolved
CvX
approved these changes
Sep 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, changing the value of the reminder frequency on a user notifications page was not working.
This commit also get rid of a few deprecations warning.