Skip to content
This repository was archived by the owner on Jul 14, 2025. It is now read-only.

FIX: Hide footer action button when user cannot assign #319

Merged
merged 3 commits into from
Apr 26, 2022
Merged

FIX: Hide footer action button when user cannot assign #319

merged 3 commits into from
Apr 26, 2022

Conversation

nattsw
Copy link
Contributor

@nattsw nattsw commented Apr 26, 2022

Fixes https://meta.discourse.org/t/public-assigns-shows-reassign-button/224860

When “public assigns” is enabled in the assign plugin, a regular user sees a drop down button which looks like they are able to reassign the topic. The button does not actually work though.

tgxworld
tgxworld reviewed Apr 26, 2022
View reviewed changes
tgxworld
tgxworld reviewed Apr 26, 2022
View reviewed changes
tgxworld
tgxworld approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@tgxworld tgxworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from some minor comments, fix looks good to me.

nattsw and others added 2 commits April 26, 2022 14:16
@nattsw @tgxworld
Correct test description
5a0cd04 
Co-authored-by: Alan Guo Xiang Tan <gxtan1990@gmail.com>
@nattsw
Update test description
9c2b5c7
@nattsw nattsw merged commit 21d8917 into main Apr 26, 2022
@nattsw nattsw deleted the public-assign-see branch April 26, 2022 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@tgxworld tgxworld tgxworld approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nattsw @tgxworld