Skip to content

FIX: Update plugin outlet component based on core FormKit conversion #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

Drenmi
Copy link
Contributor

@Drenmi Drenmi commented Oct 17, 2024

What is this change?

In discourse/discourse#29070 we converted the core user custom field form in the admin area to FormKit. We accidentally removed the plugin outlet used by this plugin. It was added back in discourse/discourse#29247.

This commit updates the plugin to FormKit as well.

@Drenmi Drenmi force-pushed the fix/core-form-kit-conversion branch 2 times, most recently from 6095645 to de1bfb7 Compare October 17, 2024 05:51
@Drenmi Drenmi force-pushed the fix/core-form-kit-conversion branch from de1bfb7 to 1a54497 Compare October 17, 2024 05:54
@Drenmi Drenmi marked this pull request as ready for review October 17, 2024 05:55
@Drenmi Drenmi requested a review from CvX October 17, 2024 05:59
Copy link

@martin-brennan martin-brennan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to add a system spec to cover this case :) I see we have some in this plugin already, but must not have covered this specific area

@Drenmi Drenmi merged commit 88e5e73 into main Oct 17, 2024
5 checks passed
@Drenmi Drenmi deleted the fix/core-form-kit-conversion branch October 17, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants