Skip to content

FIX: Ignore incoming webhook events if plugin is disabled #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 8, 2020
Merged

FIX: Ignore incoming webhook events if plugin is disabled #39

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/controllers/discourse_code_review/code_review_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ class CodeReviewController < ::ApplicationController
skip_before_action :check_xhr, only: [:webhook, :redirect]

def webhook
return render json: { disabled: true } unless SiteSetting.code_review_enabled

if SiteSetting.code_review_github_webhook_secret.blank?
Rails.logger.warn("Make sure you set a secret up in code_review_github_webhook_secret")
Expand Down
11 changes: 11 additions & 0 deletions spec/requests/discourse_code_review/code_review_controller_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,17 @@
end
end

context "#webhook" do
it "does nothing when the site setting is disabled" do
SiteSetting.code_review_enabled = false

post '/code-review/webhook'

expect(response.status).to eq(200)
expect(response.parsed_body).to eq("disabled" => true)
end
end

context "signed in as an admin" do
fab!(:signed_in_user) { Fabricate(:admin) }
fab!(:another_admin) { Fabricate(:admin) }
Expand Down