Skip to content

A11Y: Update labels for dropdown and sidebar #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2024
Merged

A11Y: Update labels for dropdown and sidebar #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4589e60
A11Y: Update labels for dropdown and sidebar
Grubba27 Jun 11, 2024
071d6e4
Merge branch 'main' into a11y/update-labels-for-dropdown-and-sidebar
Grubba27 Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/connectors/bread-crumbs-right/custom-topic-lists-dropdown.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export default class CustomTopicListsDropdown extends Component {

comboBoxOptions = {
filterable: true,
none: "custom_topic_lists_button.label",
none: "custom_topic_lists.dropdown",
caretDownIcon: "caret-right",
caretUpIcon: "caret-down",
headerComponent: "tag-drop/tag-drop-header",
Expand Down
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/initializers/initializer-breadcrumbs-topic-lists.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default {
(BaseCustomSidebarSection, BaseCustomSidebarSectionLink) => {
return class extends BaseCustomSidebarSection {
name = "custom-topic-lists";
text = I18n.t("custom_topic_lists_button.label");
text = I18n.t("custom_topic_lists.sidebar");
links = customTopicsToShow.map(({ icon, name, slug }) => {
return new (class extends BaseCustomSidebarSectionLink {
name = name;
Expand Down
5 changes: 3 additions & 2 deletions config/locales/client.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,6 @@ en:
js:
discourse_custom_topic_lists:
placeholder: placeholder
custom_topic_lists_button:
label: "Custom lists"
custom_topic_lists:
dropdown: "Custom lists"
sidebar: "Custom lists"
5 changes: 3 additions & 2 deletions config/locales/server.en.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
en:
custom_topic_lists_button:
label: "Custom lists"
custom_topic_lists:
dropdown: "Custom lists"
sidebar: "Custom lists"
2 changes: 1 addition & 1 deletion spec/system/custom_topic_lists_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ def self.add_json(*jsons)
visit "/"

list = find("div[data-section-name='custom-topic-lists']")
expect(list).to have_text(I18n.t("custom_topic_lists_button.label"))
expect(list).to have_text(I18n.t("custom_topic_lists.sidebar"))

find("li[data-list-item-name='New questions']").click
expect(page).to have_text(topic0.title)
Expand Down