FEATURE: Make user status on mentions on docs live #117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewPrigorshnev
force-pushed
the
feature/make-user-status-on-mentions-on-docs-live
branch
2 times, most recently
from
9d9d056 to
a07cf16
Compare
AndrewPrigorshnev
changed the title
AndrewPrigorshnev
force-pushed
the
feature/make-user-status-on-mentions-on-docs-live
branch
from
a07cf16 to
bbf120d
Compare
| if (post.mentioned_users) { | ||
| post.mentioned_users = post.mentioned_users.map((u) => User.create(u)); | ||
| } | ||
| }, |
There was a problem hiding this comment.
We just need to make sure users data are wrapped into user models to make status live.
CvX
approved these changes
Mar 23, 2023
AndrewPrigorshnev
deleted the
feature/make-user-status-on-mentions-on-docs-live
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes status on mentions in docs receive live updates from the server.