Skip to content

DEV: update routing to allow for open_in_new_tab #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2022
Merged

DEV: update routing to allow for open_in_new_tab #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 0 additions & 9 deletions assets/javascripts/discourse/components/docs-topic-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,6 @@ export default Component.extend({
return order === "activity";
},

// need to handle clicks here since links are in a raw view
click(e) {
if (e.target.classList.contains("docs-topic-link")) {
const topicId = e.target.dataset.topicId;
this.selectTopic(topicId);
return false;
}
},

@action
sortListActivity() {
this.sortBy("activity");
Expand Down
7 changes: 0 additions & 7 deletions assets/javascripts/discourse/controllers/docs-index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,13 +263,6 @@ export default Controller.extend({
});
},

@action
setSelectedTopic(topicId) {
this.set("selectedTopic", topicId);

window.scrollTo(0, 0);
},

@action
onChangeFilterSolved(solvedFilter) {
this.set("filterSolved", solvedFilter);
Expand Down
1 change: 0 additions & 1 deletion assets/javascripts/discourse/templates/docs-index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,6 @@
ascending=ascending
order=orderColumn
sortBy=(action "sortBy")
selectTopic=(action "setSelectedTopic")
loadMore=(action "loadMore")
loading=isLoadingMore
}}
Expand Down
2 changes: 1 addition & 1 deletion assets/javascripts/discourse/templates/docs-topic-link.hbr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<a data-topic-id="{{topic.id}}" class="docs-topic-link">{{{topic.fancyTitle}}}</a>
<a href="/docs?topic={{topic.id}}" class="docs-topic-link">{{{topic.fancyTitle}}}</a>