This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FEATURE: use GitHub API for granting badges instead of cloning repos #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cloning very large repos is an expensive operation that can cause significant overhead on the server. This change will make the plugin use the GitHub API for granting badges. The way it works is it keeps track of commits in the `github_commits` table, and then every 4 hours it'll check for new commits and grant badges to users who qualify. The first time the job is run it'll try to build the entire git histroy in the table. If the GitHub API rate limit us, then the next run will resume building the history from where it stopped last time. Providing a GitHub token via site settings is required in order for the badges to be granted to users. The token doesn't need any permissions unless one of the target repos is private.
|
@OsamaSayegh One request: Now that it's API based and doesn't require clones, it would be great to support the same syntax as the linkback feature to define what repos to watch. I mostly just want that to be able to monitor |
|
@majakomel can you review this PR ? |
This setting will make the "Settings" button show up for this plugin at /admin/plugins
SamSaffron
reviewed
Jun 26, 2019
app/lib/github_badges.rb
Outdated
| BADGE_NAME_SILVER ||= 'Great contributor'.freeze | ||
| BADGE_NAME_GOLD ||= 'Amazing contributor'.freeze | ||
|
|
||
| COMMITER_BADGE_NAME_BRONZE ||= 'Committer'.freeze |
There was a problem hiding this comment.
note ... no need for .freeze here # frozen_string_literal: true
SamSaffron
reviewed
Jun 26, 2019
|
|
||
| def is_pr?(commit) | ||
| commit.commit.author.name != commit.commit.committer.name && commit.commit.committer.name != "GitHub" | ||
| # GitHub has a special account that acts as the committer of commits that are |
|
I say do the minor fixed to remove the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.