This repository was archived by the owner on Jun 19, 2025. It is now read-only.
FEATURE: retrieve user avatar #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add specs
| @@ -18,7 +18,7 @@ class DiscourseLoginClientStrategy < ::OmniAuth::Strategies::OAuth2 | |||
| username: access_token.params["info"]["username"], | |||
| name: access_token.params["info"]["username"], | |||
| email: access_token.params["info"]["email"], | |||
| # image: for avatar? | |||
| image: access_token.params["info"]["image"], | |||
There was a problem hiding this comment.
Consider adding a fallback mechanism for cases when the 'image' key is missing in access_token.params["info"] to avoid returning nil and potentially causing issues in downstream code.
Suggested change
| image: access_token.params["info"]["image"], | |
| image: access_token.params["info"].fetch("image", ""), |
Copilot uses AI. Check for mistakes.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add specs.
Internal ref - t/150933