This repository was archived by the owner on Jul 22, 2025. It is now read-only.
FIX: Migration was only done for first batch #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nattsw
commented
Mar 25, 2025
...20250325074111_copy_remaining_solved_topic_custom_field_to_discourse_solved_solved_topics.rb
Outdated
Show resolved
Hide resolved
tgxworld
reviewed
Mar 25, 2025
db/migrate/20250318024953_copy_solved_topic_custom_field_to_discourse_solved_solved_topics.rb
Outdated
Show resolved
Hide resolved
tgxworld
reviewed
Mar 25, 2025
db/migrate/20250318024953_copy_solved_topic_custom_field_to_discourse_solved_solved_topics.rb
Show resolved
Hide resolved
tgxworld
approved these changes
Mar 25, 2025
nattsw
force-pushed
the
fix-migration-gap
branch
from
c546fbc to
f93c9c4
Compare
nattsw
force-pushed
the
fix-migration-gap
branch
from
f93c9c4 to
64567d9
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#342 was deployed and observed to only have 5000 (batch size) migrated. This is an error in migration where the ids had a gap between the batch.
This PR changes the migration to just loop through all topic custom fields with each loop increasing by batch size.