fix site_setting disable_emails arguments #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API changed from boolean to enum: now you can use 'yes' (instead of true), 'no' (instead of false), and 'non-staff' to forbid Discourse from sending emails except for Staff.
|
Awesome, thanks! Looks good, expect for it looks like you accidentally deleted the description for |
|
Ooops, sorry, I did not see the notification. The last commit should have fixed it. Thanks for the catch @oblakeerickson. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API changed from boolean to enum:
now you can use 'yes' (instead of true), 'no' (instead of false),
and 'non-staff' to forbid Discourse from sending emails except
for Staff.