Add embed_url to topic create method #26
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for making this PR! Just thought I'd message you real quick. This is totally on me, but the README instructions need to be updated as we have moved the openapi.yml/.json generation to inside the discourse/discourse repo and are using rswag to generate the api docs rather than manually editing the files in the repo. You will want to look into this file: https://github.com/discourse/discourse/blob/main/spec/requests/api/posts_spec.rb#L100 and the referenced schema files located in: https://github.com/discourse/discourse/tree/main/spec/requests/api/schemas/json I'll work on providing better instructions in the README, but not something I can get done tonight. Please reach out if you need help. |
oblakeerickson
added a commit
to discourse/discourse
that referenced
this pull request
Nov 4, 2021
When creating a topic via the api you can pass in the `embed_url` param, so adding this to the api docs. See: discourse/discourse_api_docs#26
oblakeerickson
added a commit
to discourse/discourse
that referenced
this pull request
Nov 4, 2021
When creating a topic via the api you can pass in the `embed_url` param, so adding this to the api docs. See: discourse/discourse_api_docs#26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
POST /topics.jsonmethod acceptsembed_url, this PR adds that to the documentation.This would have saved me a lot of headache in a blog comment migration project as documented on the meta forum.