Improve UX around verification keys #120
Merged
+112
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achille-roussel
approved these changes
Mar 10, 2024
Comment on lines
+143
to
+146
| # Be forgiving when accepting keys in PEM format, which may span | ||
| # multiple lines. Users attempting to pass a PEM key via an environment | ||
| # variable may accidentally include literal "\n" bytes rather than a | ||
| # newline char (0xA). |
There was a problem hiding this comment.
Good thinking on this one 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verification keys can now be provided in either PEM format, or as a base64-encoded string.
This fixes #115.