Skip to content

Add Python 3.3+ support. #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add Python 3.3+ support. #25

wants to merge 1 commit into from

Conversation

berkerpeksag
Copy link

No description provided.

@mattrobenolt
Copy link
Collaborator

Can we avoid depending on six and just vendorize the few functions we need? I generally don't like to depend on six in a simple library. I feel six is more valuable in a larger project. I've seen issues with version compatibilities in different versions of six which broke the world before in a library.

@berkerpeksag
Copy link
Author

Can we avoid depending on six and just vendorize the few functions we need?

Done.

Thanks for the review.

@@ -1,2 +1,2 @@
include setup.py README.rst MANIFEST.in LICENSE phabricator/interfaces.json
include setup.py README.rst MANIFEST.in LICENSE phabricator/interfaces.json setup.cfg tox.ini
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shouldn't need to include setup.cfg or tox.ini. Is there a reason these were added?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, they are not needed. Removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants