Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(component): add blockquote component #5

Merged
merged 1 commit into from
Oct 12, 2023
Merged

feat(component): add blockquote component #5

merged 1 commit into from
Oct 12, 2023

Conversation

jtfairbank
Copy link
Collaborator

@jtfairbank jtfairbank commented Oct 10, 2023 •
edited
Loading

Create a Puck component config for Radix Blockquote.

Props

  • text* string as child content
  • 4 size options
  • all weight options

* = required

Features

  • ☑️ dynamic layout
  • ☑️ editable content

Next Steps

  • 🏗️ add support for child Components
  • ♻️ refactor so the Markdown component and the Blockquote component both use the same render function for blockquotes
  • 🧠 figure out how to expose margin and color properties on all Radix components

@jtfairbank jtfairbank added the type | enhancement New & improved functionality, content, processes, etc. label Oct 10, 2023
@vercel
Copy link

vercel bot commented Oct 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
next-website ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 7:47pm

@jtfairbank jtfairbank marked this pull request as ready for review October 10, 2023 19:46
@jtfairbank jtfairbank force-pushed the add-blockquote-component branch from 2233d92 to f495f25 Compare October 10, 2023 19:47
akuankka128
akuankka128 approved these changes Oct 11, 2023
View reviewed changes
Copy link

@akuankka128 akuankka128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me.

@jtfairbank jtfairbank added scope | editor Involves the admin dashboard, editor, custom data-input fields, and related plugins. scope | frontend Involves the display of pages / components. status | followup A maintainer should followup after the Issue or PR is resolved (to prepare next steps, etc). labels Oct 12, 2023
@jtfairbank jtfairbank merged commit e788862 into saga Oct 12, 2023
2 checks passed
@jtfairbank jtfairbank deleted the add-blockquote-component branch October 12, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akuankka128 akuankka128 akuankka128 approved these changes

Assignees
No one assigned
Labels
scope | editor Involves the admin dashboard, editor, custom data-input fields, and related plugins. scope | frontend Involves the display of pages / components. status | followup A maintainer should followup after the Issue or PR is resolved (to prepare next steps, etc). type | enhancement New & improved functionality, content, processes, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtfairbank @akuankka128