Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor topic to three separate tasks #123

Closed
wants to merge 1 commit into from
Closed

Refactor topic to three separate tasks #123

wants to merge 1 commit into from

Conversation

lionelmoi
Copy link
Contributor

@lionelmoi lionelmoi commented Dec 5, 2016

Refactored the topic to include three separate tasks as each customization can be performed independently.

@infotexture infotexture changed the title refactored the topic to include three separate taks as each customization can be performed independently. Refactor topic to three separate tasks Dec 5, 2016
@infotexture infotexture added refactoring Changes to organization of docs source webedit Changes submitted via oXygen Web Author wontfix This will not be worked on labels Dec 5, 2016
@infotexture
Copy link
Member

infotexture commented Dec 7, 2016

Closing this as wontfix for several reasons:

  • Edits conflict with changes in 63ddd36 for Clarify CSS parameters in <context> #122
  • Commit d14cb0f introduced CRLF line endings, which would require re-normalization
    (looks like oXygen Web Author did not respect .gitattributes)
  • Nested task topics don’t work well with Related Links

The initial idea of splitting the step sections into dedicated tasks is worth considering, but to facilitate re-use, the hierarchy should be determined by <topicref> elements in the map rather than nesting <task> elements in a single file.

@infotexture infotexture closed this Dec 7, 2016
infotexture added a commit that referenced this pull request Dec 7, 2016
Signed-off-by: Roger Sheen <roger@infotexture.net>
infotexture added a commit that referenced this pull request Dec 7, 2016
* develop: (39 commits)
  Provide context on `nav-toc` for HTML5 navigation
  Clarify use case for CSS parameters vs. plugin
  Add sample CSS to header customization example
  Promote navigation example
  Adjust link order, add family collection-type
  Add step to include custom footer
  Refactor HTML customization to sub-tasks #123
  Remove unnecessary `type` attributes
  Link HTML-based output parameters to related topics
  Sync CSS parameter details w/ Parameter Reference
  Clarify CSS parameters
  Draft topic on bundling custom CSS in plug-in #118
  Draft topic on custom HTML .properties file #118
  Use new double-hyphen syntax in transtype topics
  Link parameter-based customization to related topics
  Draft topic on parameter-based customization #118
  Add section stubs for Customizing HTML output #118
  Fix xml-apis DOM name
  Update & re-use version keys for bundled software
  Move key definitions for external links to submap
  ...
infotexture added a commit that referenced this pull request Dec 10, 2016
* hotfix/2.4.1: (50 commits)
  Move "Third-party software" to new “License” item
  Add info on dita-ot/dita-ot#2539 to 2.4.1 RN
  Add info on dita-ot/dita-ot#2537 to 2.4.1 RN
  Add info on dita-ot/dita-ot#2529 to 2.4.1 RN
  Add info on dita-ot/dita-ot#2526 to 2.4.1 RN
  Add info on dita-ot/dita-ot#2524 to 2.4.1 RN
  Update force-unique info for dita-ot/dita-ot#2520
  Add section on documentation updates in 2.4.1
  Add keys for internal references
  Add list of resolved issues to 2.4.1 Release Notes
  Bump 'maintenance-version' key to “2.4.1”
  Provide context on `nav-toc` for HTML5 navigation
  Clarify use case for CSS parameters vs. plugin
  Add sample CSS to header customization example
  Promote navigation example
  Adjust link order, add family collection-type
  Add step to include custom footer
  Refactor HTML customization to sub-tasks #123
  Remove unnecessary `type` attributes
  Link HTML-based output parameters to related topics
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Changes to organization of docs source webedit Changes submitted via oXygen Web Author wontfix This will not be worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants