Updated docs #3363
Merged
Updated docs #3363
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I added a warning about returning non-utf8-encoded strings from within ``def __unicode__()``, as I found it resulting in a 500 response and a plugin instance marked as <Empty>. After returning as UTF8 everything worked as expected. If you can't confirm these issues to be related or feel that the addition doesn't make sense for documentation readers, feel free to drop it.
|
It's already documented here: https://docs.djangoproject.com/en/dev/ref/unicode/#models . You should also consider using |
|
Yes, normally I import the unicode_literals, took some time until I've noticed that they were missing. I was going to mention that it is more of a Django issue, but the advantage in plain Django is that you see the quite verbose exception directly, while when happening in DCMS there is no visible error on screen and the exception is not printed out on the terminal, just one line with a 500 response code in runserver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a warning about returning non-utf8-encoded strings from within
def __unicode__(), as I found it resulting in a 500 response and a plugin instance marked as<Empty>. After returning asUTF8everything was working as expected. If you can't confirm these issues to be related, feel that the addition is not accurate enough or doesn't make sense for documentation readers, feel free to drop it.