Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plane: Always departs loiter WP towards next WP #1906

Closed
iskess opened this issue Feb 22, 2015 · 17 comments
Closed

Plane: Always departs loiter WP towards next WP #1906

iskess opened this issue Feb 22, 2015 · 17 comments
Labels

Comments

@iskess
Copy link

iskess commented Feb 22, 2015

I like to use the LOITER_TURNS command to create a short holding pattern to allow the airplane to stabilize its altitude before continuing with the approach to auto land. The problem is the plane is not consistent with the direction it departs the Loiter, and will often depart in the wrong direction creating a very irregular and unpredictable approach path. I don't see any reason why the code shouldn't require the departure from loiter to always be in the direction of the next waypoint. I realize this might not give you exactly the number of turns you requested, depending on where you entered the Loiter, but that variability is preferable over flight path uncertainty.

@tridge tridge added the Plane label Feb 23, 2015
@tridge tridge added this to the Plane 3.3.0 milestone Feb 23, 2015
@tridge
Copy link
Contributor

tridge commented Feb 23, 2015

yes, I agree. To make it consistent we'd probably make it break out of the loiter the next time a vector directly out the front of the aircraft crosses the next WP target.

@iskess
Copy link
Author

iskess commented Feb 23, 2015

That would be perfect! Thank you.

@magicrub
Copy link
Contributor

fixed with #1981

@iskess
Copy link
Author

iskess commented Feb 28, 2016

Still having problems with exiting loiter on the correct heading.
loiter exit

2016-02-25 13-31-52.zip

@magicrub
Copy link
Contributor

I agree this should be fix/changed. Meanwhile, have you tried
loiter-to-alt? It has a heading to next waypoint optional requirement which
is exactly what you want.
On Feb 27, 2016 11:12 PM, "Iam Bouret" notifications@github.com wrote:

Still having problems with exiting loiter on the correct heading.
[image: loiter exit]
https://cloud.githubusercontent.com/assets/4913946/13377955/83044028-dd96-11e5-87e0-5aa40aa38c06.JPG

2016-02-25 13-31-52.zip
https://github.com/diydrones/ardupilot/files/149776/2016-02-25.13-31-52.zip


Reply to this email directly or view it on GitHub
#1906 (comment)
.

@iskess
Copy link
Author

iskess commented Feb 28, 2016

Tom, can you reopen this issue?
I didn't use loiter to alt in this case because I use the two loiter turns to buy me time to get mentally prepared for the approach. I could have used loiter time, but I wanted the loiter to end heading the correct direction, and I'm not sure if loiter time will exit immediately when the time expires.

@magicrub magicrub reopened this Feb 28, 2016
@magicrub
Copy link
Contributor

reopened. There is a new command loiter-to-alt but I agree that all loiter commands should have this behavior.

@iskess
Copy link
Author

iskess commented Feb 28, 2016

Strange, it was working great for a while there, now it's broken again.

@magicrub
Copy link
Contributor

it was luck then of when it started, it's never had that feature.

On Sun, Feb 28, 2016 at 3:06 PM, Iam Bouret notifications@github.com
wrote:

Strange, it was working great for a while there, now it's broken again.


Reply to this email directly or view it on GitHub
#1906 (comment)
.

@WickedShell
Copy link
Contributor

Shouldn't that be optional? IE if my radius is large a faster flight path
would actually be to just leave the loiter regardless so that the plane can
pull it's max bank rate to get there?

Although I agree that this is very reasonable default behavior to always
exit towards the next WP, as that is what people probably expect
intuitively.

On Sun, Feb 28, 2016 at 4:03 PM, Tom Pittenger notifications@github.com
wrote:

reopened. There is a new command loiter-to-alt but I agree that all loiter
commands should have this behavior.


Reply to this email directly or view it on GitHub
#1906 (comment)
.

@iskess
Copy link
Author

iskess commented Feb 29, 2016

Sorry, I'm not following. Could you try to explain again? Why would I be loitering if I want the fastest flight path?

@WickedShell
Copy link
Contributor

Loiter to alt is usually where I use it, although there is also an argument
for loiter time. . IE I tookoff executed takeoff logic to 50 m but want to
ensure I'm safely clear of all obstacles enroute to the mission so I then
have a loiter to alt to take me to 125m then I want to go to the next point
in the mission.

On Sun, Feb 28, 2016 at 6:23 PM, Iam Bouret notifications@github.com
wrote:

Sorry, I'm not following. Could you try to explain again? Why would I be
loitering if I want the fastest flight path?


Reply to this email directly or view it on GitHub
#1906 (comment)
.

@iskess
Copy link
Author

iskess commented Feb 29, 2016

My example was loiter turns, but I do do your point with loiter time, or loiter to alt.

@magicrub
Copy link
Contributor

there's an option in loiter-to-alt, I'm sure it can be extended to the
rest.

On Sun, Feb 28, 2016 at 5:33 PM, Iam Bouret notifications@github.com
wrote:

My example was loiter turns, but I do do your point with loiter time, or
loiter to alt.


Reply to this email directly or view it on GitHub
#1906 (comment)
.

@magicrub
Copy link
Contributor

magicrub commented Mar 1, 2016

pending PR #3694

@OXINARF OXINARF removed this from the Plane 3.3.0 milestone Jan 7, 2017
@OXINARF
Copy link
Member

OXINARF commented Jan 7, 2017

@iskess @magicrub Was this fixed with #3694?

@magicrub
Copy link
Contributor

magicrub commented Jan 7, 2017 via email

@iskess iskess closed this as completed Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants