New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ArduCopter: make ROI persistent across waypoints #569
Comments
(1) - where on the wiki did you see this? This is the new wiki by the way: http://copter.ardupilot.com/wiki/introduction/ |
Randy, #1: In the new wiki, on the page about planning missions with waypoints and events, a table is posted with 4 options that control/influence yaw behaviour. Directly below the explanation of the DO_SET_ROI command. At least it's my interpretation the options can be used for that purpose. Best regards, Jan Willem Verstuurd vanaf mijn iPad
|
I have the same problem running AC3.1-Rc2. For me if I set ROI after several waypoints it stop executing any more waypoints or commands, it loops forever in loiter. When using Do_Set_ROI I have the same "issue" as mentioned above. After setting Do_Set_ROI it points to the ROI location, however on the next WP command it goes back to pointing to the next waypoint. I have to set WP, Do_Set_ROI, WP, Do_Set_ROI alternating like that doubling up the commands for ROI to work, and I don't think that is the intended way for it to be controlled/set. I see in the description of So_Set_ROI that there is an option 0 - 4 for setting the YAW behaviour. http://planner.ardupilot.com/wiki/common-planning-a-mission-with-waypoints-and-events/ I don't think the Do_Set_ROI needs to change in the way it works (the one-shot part) as there seems to be a valid set of options in the command to control yaw behaviour? Unless I am misreading that and those options are also intended to be one-shot? edit: Unfortunately you can't see the commands above the WP ones, but here on the Mission Planner you can see a single ROI point, and no one is setting Do_Set_ROI after each waypoint. I would think this is the way ROI is intended to work? |
I'd like to add ROI and YAW direction, when intentionally set, should persist across WPs in yaw mode == 0 (never change yaw). Or shall we make special mode. So, when planning missions you may fly through one part of it (multiple WPs) with first ROI or YAW direction, then change ROI or YAW, fly next part and so on. May be it would be good to add ability to change WP_YAW_BEHAVIOR in flight for example by passing negative numbers to CONDITION_YAW. If one makes missions containing ROI or YAW commands it's goal is usually photography of filming. And when you're filming, you never want camera to travel straight lines. |
I can confirm that I get the same problem as well. I performed an automatic mission where I needed to keep my quadcopter (running APM:C 3.1rc5) pointed the same direction. I attempted to accomplish this by using DO_SET_ROI with the option set to "0" per the wiki: http://copter.ardupilot.com/wiki/common-planning-a-mission-with-waypoints-and-events/#Basic_waypoint_commands-2 so that it would maintain orientation. However, it only persisted for one waypoint, then continued to point at the next waypoint. According to the wiki, DO_SET_ROI should persist until the APM is rebooted. |
Ok, I've removed the incorrect information from that wiki page. txs! |
If we were to make ROI persistent between waypoints, we would also need some mechanism for cancelling it, i.e. to return to the default yaw behaviour as specified by WP_YAW_BEHAVIOR. |
^^ adding to the comment above, we would also need to understand how, if a persistent ROI is implemented, what would happen when encountering LOITER_TURNS. I'd suspect it would cancel the ROI, and one would have to add another DO_SET_ROI to reestablish it if desired. |
The ROI behaviour has been changed in master now so that it's persistent across waypoints. You can revert the yaw behaviour to the default (i.e. face towards next waypoint) by providing an all zero ROI command. This should go out with AC3.2 but it also needs to be tested before then. |
This is a great news Randy! Thanks! Luciano |
I'm going to close this item because it's fixed in master. I'll be coming up with a to-be-tested list once the AC3.2 release candidate is ready. I expect the first release candidate will be out in about a month (could be less). |
Was this ever fixed? I would REALLY like it to be. I am still using AC 3.1 and am sick of plugging a ROI between every waypoint. |
I'm going to test it this week. I let you know.... :) Luciano -------- Messaggio originale -------- Was this ever fixed? I would REALLY like it to be. I am still using AC 3.1 and am sick of plugging a ROI between every waypoint. — |
After testing firmware 3.1 rc2 it appears ROI is not functioning as it should/could.
The text was updated successfully, but these errors were encountered: