-
Notifications
You must be signed in to change notification settings - Fork 16.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding RSSI library to allow for PWM channel value RSSI - rework #1 #2770
Conversation
…I, with the possibility of adding more. * Retains ability to read from Analog Pin * Adds ability to read RSSI from PWM channel value as is done in OpenLRSng, EazyUHF, and various other LRS. * Handles any type of RSSI that provides RSSI values inverted - i.e. when the low value is the best signal and the high value is the worst signal. * Has different key names from all existing RSSI parameters to provide for a clean break and easier distinguishing.
… the possibility of adding more. * Retains ability to read from Analog Pin * Adds ability to read RSSI from PWM channel value as is done in OpenLRSng, EazyUHF, and various other LRS. * Handles any type of RSSI that provides RSSI values inverted - i.e. when the low value is the best signal and the high value is the worst signal. * Has different key names from all existing RSSI parameters to provide for a clean break and easier distinguishing. * Existing parameters are marked as obsolete
…h the possibility of adding more. * Retains ability to read from Analog Pin * Adds ability to read RSSI from PWM channel value as is done in OpenLRSng, EazyUHF, and various other LRS. * Handles any type of RSSI that provides RSSI values inverted - i.e. when the low value is the best signal and the high value is the worst signal. * Has different key names from all existing RSSI parameters to provide for a clean break and easier distinguishing. * Existing parameters are marked as obsolete
… the possibility of adding more. * Retains ability to read from Analog Pin * Adds ability to read RSSI from PWM channel value as is done in OpenLRSng, EazyUHF, and various other LRS. * Handles any type of RSSI that provides RSSI values inverted - i.e. when the low value is the best signal and the high value is the worst signal. * Has different key names from all existing RSSI parameters to provide for a clean break and easier distinguishing. * Existing parameters are marked as obsolete
thanks for a great implementation! I've pushed it to master |
Will this make it into Plane 3.4.0? Or just subsequent releases? |
It will make Plane 3.4.0. Thanks! |
What about Copter? :) |
@nicbk117, I'm afraid it won't make it into AC3.3 but it'll be in AC3.4. |
I've left comments on issues/PRs where appropriate, but I believe the following should be closed by this PR: #1377 - MAX and MIN RX RSSI value The rest (see references above) aren't 100% satisfied by this PR or are already closed. |
Merged RSSI_CHANNEL support by Stewart Loving-Gibbard from PR ArduPilot#2770
Merged RSSI_CHANNEL support by Stewart Loving-Gibbard from PR ArduPilot#2770
This is a resubmit of #2765 after changes requested by @tridge.
Adding ability and controlling parameters for reading RSSI value from a PWM channel value. This is a feature supported by various radio receivers such as those running OpenLRSng, EzUHF, etc.
Making a new library AP_RSSI to be a uniform place to call read_receiver_rssi.
Retains ability to read analog pin for RSSI values, improves flexibility of relevant ranging a bit.
Adds ability to read RSSI from a particular channel's PWM channel value.
Previous RSSI parameters have been all deprecated in favor of these new ones, and they all have new names. Users will need to re-configure RSSI in order to use these new ones.
Tested on Plane, Copter, and Rover.
Continuation of work started on PR #2731. See also #2721; this PR anticipates the development of other RSSI methods.