Changed SSL socket handling #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see a existing modification in another fork, is solution undesirable? |
|
Hi, The ssl module was new in Python 2.6, so I deliberately used the ssl function from the socket module for better backwards compatibility. (I ended up running a push server on some rented host that had an archaic version of Python installed on it.) For that reason I'm going to hold off pulling this change as it is. |
|
Make sense. Thanks for reviewing. |
|
This is where I reveal my ignorance of Github... what's a versioned fork? :-) |
ghost
assigned
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Had a small bug when trying to use this under eventlet.
Made a couple tweaks to store the socket wrapped to resolve the issue.