Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requirement files #62

Merged
merged 15 commits into from
Apr 17, 2021
Merged

Add requirement files #62

merged 15 commits into from
Apr 17, 2021

Conversation

crydotsnake
Copy link
Contributor

No description provided.

@crydotsnake
Copy link
Contributor Author

Wait.. i think i have to move the requirements folder too tests/requirements and then, delete the requirements.txt in tests

@crydotsnake
Copy link
Contributor Author

Is that correct? @marksweb

@marksweb
Copy link
Member

Is that correct? @marksweb

Not quite. Create a requirements directory. Move requirements.txt into it and rename it base.txt

Then add the other files.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2021

Codecov Report

Merging #62 (79438f8) into master (bd74d8f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        14    +1     
  Lines          215       216    +1     
  Branches         8         8           
=========================================
+ Hits           215       216    +1     
Impacted Files Coverage Δ
...ocms_video/migrations/0007_create_nested_plugin.py 100.00% <100.00%> (ø)
djangocms_video/models.py 100.00% <100.00%> (ø)
djangocms_video/__init__.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd74d8f...79438f8. Read the comment docs.

@crydotsnake
Copy link
Contributor Author

@marksweb Now it looks better.. but the Lint check has failed..

@marksweb
Copy link
Member

@marksweb Now it looks better.. but the Lint check has failed..

Yeah just import order. Easy fix.

Details here https://github.com/django-cms/djangocms-video/runs/2368886690

@crydotsnake
Copy link
Contributor Author

You mean it should look like that?

isort
django-app-helper
tox
coverage
flake8

@crydotsnake
Copy link
Contributor Author

Idk how too fix it 😓

@marksweb
Copy link
Member

You mean it should look like that?

isort
django-app-helper
tox
coverage
flake8

Yeah that would be the base requirements which are needed by each Django version we test against.

So that would be included at the top of each of the other requirement files.

@crydotsnake
Copy link
Contributor Author

@marksweb The check has failed again. Have I forgotten a requirements file?

@marksweb marksweb merged commit e5621b7 into django-cms:master Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants