Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

queryset update() and EmbeddedModelField #13

Closed
gpitfield opened this issue Feb 1, 2012 · 3 comments
Closed

queryset update() and EmbeddedModelField #13

gpitfield opened this issue Feb 1, 2012 · 3 comments

Comments

@gpitfield
Copy link
Member

New home for django-nonrel/mongodb-engine#103
@gpitfield
Copy link
Member Author

OK, I've got a patch that fixes this, passes tests, etc. [Well, it passes all the tests except for one that it didn't pass before I started which is totally unrelated to the change.]

I can't seem to push a new fork up though, maybe I need some sort of privilege or whatever to do that? Please let me know what needs to be done so I can push this up for you to take a look at.

@gpitfield
Copy link
Member Author

Ah, nevermind that. I think I misunderstood how forking works, so I'll do that properly and see if it works.

gpitfield added a commit to gpitfield/djangotoolbox that referenced this issue Feb 2, 2012
@gpitfield
Improves EmbeddedModelField save behaviour to address issue django-no…
d855d00 
…nrel#13

Removes pre_save() function entirely, moving its functionality
into get_db_prep_value. Among other things, this means that
queryset update() calls on EmbeddedModelFields work
wrwrwr added a commit that referenced this issue Feb 7, 2012
@wrwrwr
Test for list with embedded instances update problem (issue #13).
ef87e04
wrwrwr added a commit that referenced this issue Feb 7, 2012
@wrwrwr
Introduced changes fixing EmbeddedModelField.update (issue #13). Patc…
a5173a1 
…h by gpitfield, thanks!
wrwrwr added a commit that referenced this issue Feb 10, 2012
@wrwrwr
Fix QuerySet.update for lists with embedded models; see issues #13 and …
3649112 
…#14. Patch by gpitfield, thanks!
@wrwrwr
Copy link
Member

wrwrwr commented Feb 10, 2012

Merged, thanks for the fix.

@wrwrwr wrwrwr closed this as completed Feb 10, 2012
egrim pushed a commit to egrim/djangotoolbox that referenced this issue Feb 14, 2012
@wrwrwr
Fix QuerySet.update for lists with embedded models; see issues django…
30044bc 
…-nonrel#13 and django-nonrel#14. Patch by gpitfield, thanks!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gpitfield @wrwrwr