Skip to content

Add tox test to check if migrations were missed. #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

n2ygk
Copy link
Contributor

@n2ygk n2ygk commented Jan 9, 2022

Fixes #1071

Description of the Change

Adds a test to see if a PR forgot to add a migration.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@n2ygk n2ygk requested a review from a team January 9, 2022 19:08
@n2ygk n2ygk added this to the 1.7.0 milestone Jan 9, 2022
@codecov
Copy link

codecov bot commented Jan 9, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.64%. Comparing base (94d42a8) to head (44caf5f).
Report is 206 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   96.64%   96.64%           
=======================================
  Files          31       31           
  Lines        1761     1761           
=======================================
  Hits         1702     1702           
  Misses         59       59           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@n2ygk n2ygk force-pushed the resolve_makemigrations_check_errors branch from 3f5c3f7 to 44caf5f Compare January 9, 2022 19:54
Copy link
Contributor

@auvipy auvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's very useful

@auvipy auvipy merged commit 68da292 into django-oauth:master Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure PR tests detect new missing migrations
2 participants