-
Notifications
You must be signed in to change notification settings - Fork 813
Enhance clear_expired tests. #1088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1088 +/- ##
==========================================
+ Coverage 96.65% 96.87% +0.21%
==========================================
Files 31 31
Lines 1763 1759 -4
==========================================
Hits 1704 1704
+ Misses 59 55 -4 ☔ View full report in Codecov by Sentry. |
@Andrew-Chen-Wang See 6ddb3d7 for broken commit due to: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
f-strings used for performance and readability improvement.
bulk_create
does not call save()
, but the pks are set given the database is Postgres, MariaDB, or SQLite3 (at some version+ that GitHub actions and all modern computers prob already have).
For reference, here's where it's set: https://github.com/django/django/blob/dc9deea8e85641695e489e43ed5d5638134c15c7/django/db/models/query.py#L514
Co-authored-by: Andrew Chen Wang <60190294+Andrew-Chen-Wang@users.noreply.github.com>
I'll circle back soon and make sure my test logic is correct (probably isn't) now that the code is running;-) |
… failure messages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #1065
Description of the Change
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS