Skip to content

Remove incompatible python+django version combinations from CI #1245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Qup42
Copy link
Contributor

@Qup42 Qup42 commented Jan 20, 2023

Description of the Change

The pipeline tests are failing for djmain with python < 3.10 because the main branch of django requires python >= 3.10. This PR removes the incompatible python versions from the djmain step.

Why did the tests break?

Django has released 4.2 alpha 11 with a feature freeze on 17/01/2023. This means that the main branch is now working towards 5.0 and has thus dropped python < 3.102 on 18/01/2023.

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

Footnotes

  1. https://www.djangoproject.com/weblog/2023/jan/17/django-42-alpha-1-released/

  2. https://docs.djangoproject.com/en/dev/faq/install/#what-python-version-can-i-use-with-django

@Qup42 Qup42 mentioned this pull request Jan 20, 2023
9 tasks
Copy link
Contributor

@n2ygk n2ygk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #1245 (a991f94) into master (8772ac7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1245   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files          31       31           
  Lines        1821     1821           
=======================================
  Hits         1766     1766           
  Misses         55       55           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@n2ygk n2ygk merged commit 407a6d7 into django-oauth:master Jan 20, 2023
@n2ygk n2ygk added this to the Future milestone Feb 12, 2023
@n2ygk n2ygk modified the milestones: Future, 2.3.0 May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants