fix: codecov uploads failing #1585
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codecov uploads are failing due to rate limiting see: https://github.com/jazzband/django-oauth-toolkit/actions/runs/16092121891/job/45410281627#step:8:37 codecov/feedback#735 (comment) indicated I should try oidc
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1585 +/- ##
==========================================
- Coverage 97.38% 97.37% -0.01%
==========================================
Files 34 34
Lines 2214 2212 -2
==========================================
- Hits 2156 2154 -2
Misses 58 58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
Enable OpenID Connect (OIDC) for Codecov uploads to avoid rate limiting errors.
- Grant
id-token: writepermission for OIDC token retrieval - Upgrade codecov-action from v3 to v5 and enable
use_oidc: true
Comments suppressed due to low confidence (2)
.github/workflows/test.yml:9
- When you define a custom permissions block, it overrides defaults like
contents: read. Addcontents: readalongsideid-token: writeso actions/checkout and other steps still have repository read access.
permissions:
.github/workflows/test.yml:65
- [nitpick] Consider pinning to a specific patch release (e.g.,
@v5.3.1) instead of the floating@v5tag to avoid unexpected breaking changes from future updates.
uses: codecov/codecov-action@v5
|
@n2ygk I'd love to get this merged if you're okay with it so I can get pending PRs rebased on it to assert coverage changes. |
|
@n2ygk ping. I'd love to get an approval on this to merge it. |
n2ygk
approved these changes
Jul 20, 2025
Sorry for the delay |
|
No worries. It's summer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codecov uploads are failing due to rate limiting
see: https://github.com/jazzband/django-oauth-toolkit/actions/runs/16092121891/job/45410281627#step:8:37 codecov/feedback#735 (comment) indicated I should try oidc
Description of the Change
enable oidc on codecov step of test job.
Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS