-
Notifications
You must be signed in to change notification settings - Fork 809
Fix #847 Log an exception when response status is not OK #848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #847 Log an exception when response status is not OK #848
Conversation
…is not successful By providing the status code and its reason to logger, the error message would be more explicit for debugger whenever there is an issue related to resource token or other errors.
Pull Request Test Coverage Report for Build 1405
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please add a test for the proposed change?
|
A unit test is added to check the expected logger information. |
please update the changelog and document if needed. |
A CHANGLOG is added. I have checked the documentation, currently, it seems there is no section to cover things related to APIs with the authentication server. |
By providing the status code and its reason to logger, the error message would be more explicit for debugger whenever there is an issue related to resource token or other errors.
Fixes #847
Description of the Change
Added a checker to log an exception when the response from authentication server is not successful. With such change, the real issue with the response would not be changed to a JSONDecoderError which would be a distraction for debugging.
Checklist
CHANGELOG.md
updated (only for user relevant changes)AUTHORS