Fix wrong import #930
Merged
Fix wrong import #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix wrong import from `url` (unused in example) to `path`
Codecov Report
@@ Coverage Diff @@
## master #930 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 30 30
Lines 1423 1423
=======================================
Hits 1351 1351
Misses 72 72 Continue to review full report at Codecov.
|
auvipy
previously requested changes
Mar 5, 2021
amureki
approved these changes
Mar 9, 2021
|
@auvipy You are merging without confirming the PR template was filled out (again). Please follow the process. |
|
@n2ygk my bad, apologies! I did merge it and missed the point that we do not have a proper PR description followed by a template. |
I did not merge it |
|
Apologies. I misread the log.
…On Wed, Mar 10, 2021 at 2:04 AM Asif Saif Uddin ***@***.***> wrote:
@auvipy <https://github.com/auvipy> You are merging without confirming
the PR template was filled out (again). Please follow the process.
I did not merge it
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#930 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABBHS5YTFKWW7CM7HDPYOELTC4KYZANCNFSM4YUEE2EQ>
.
|
This was referenced Mar 15, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix wrong import from
url(unused in example) topath.Fixes #
Just a quick fix.