Skip to content

Use django-cors-headers in docs #973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 2, 2021
Merged

Use django-cors-headers in docs #973

merged 3 commits into from
Sep 2, 2021

Conversation

Andrew-Chen-Wang
Copy link
Contributor

@Andrew-Chen-Wang Andrew-Chen-Wang commented May 1, 2021

References #411

Description of the Change

Change docs to use django-cors-headers instead of django-cors-middleware which has been archived as a repo. Django-cors-headers resumed maintenance.

Besides installation, INSTALLED_APPS and the rest stays the same (since django-cors-middleware was a fork).

Checklist

  • PR only contains one change (considered splitting up PR)
  • unit-test added
  • documentation updated
  • CHANGELOG.md updated (only for user relevant changes)
  • author name in AUTHORS

@codecov
Copy link

codecov bot commented May 1, 2021

Codecov Report

Merging #973 (2f7214b) into master (3716ec4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #973   +/-   ##
=======================================
  Coverage   96.55%   96.55%           
=======================================
  Files          31       31           
  Lines        1715     1715           
=======================================
  Hits         1656     1656           
  Misses         59       59           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3716ec4...2f7214b. Read the comment docs.

@auvipy auvipy merged commit 6dbde71 into master Sep 2, 2021
@auvipy auvipy deleted the django-cors-headers-docs branch September 2, 2021 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants