Setting the manager explicitly #50
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to [the way](https://github.com/chrisglass/django_polymorphic/blob/master/polymorphic/base.py) Django Polymorphic sets the `PolymorphicManager, we need to override their manager explicitly in order to make it work the way it is [supposed to](https://github.com/edoburu/django-polymorphic-tree/blob/2439464/polymorphic_tree/models.py#L80). I haven't found any other way of doing this. What do you think?
|
@jorgebg I'm not sure what to think of this issue. If polymorphic does things the wrong way, could that be fixed instead? That would help us avoiding workarounds on top. While Django's way how it's "supposed to be" is preferred, the polymorphic approach might be needed to ensure polymorphic behavior works everywhere. Any help or insight here is highly appreciated. |
|
This issue is fixed in 1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the way Django Polymorphic sets the
PolymorphicManager, we need to override their manager explicitly in order to make it work the way it is supposed to. I haven't found any other way of doing this.What do you think?