Skip to content

Conversation

chrisportela
Copy link

No description provided.

@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #62 into master will decrease coverage by 0.11%.
The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   63.89%   63.77%   -0.12%     
==========================================
  Files          12       12              
  Lines         781      784       +3     
==========================================
+ Hits          499      500       +1     
- Misses        282      284       +2
Impacted Files Coverage Δ
polymorphic_tree/managers.py 78.78% <50%> (-4.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67a6237...49c220b. Read the comment docs.

@chrisportela
Copy link
Author

Sorry I put the wrong issue number. It's #61

Important information is that I was using v1.2.0 at first and then needed the git release for a while. The version on github doesn't have manager.py in master. v1.3.0 has the manager.py file for some reason.

This is strangely inconsistent and we should still probably try importing the right one, but also try the other one, until it's more consistent in the django-polymorphic repo.

@chrisportela chrisportela changed the title Fixes #9 - importing polymorphic managers Fixes #61 - importing polymorphic managers Oct 6, 2017
@vdboor
Copy link
Member

vdboor commented Nov 22, 2017

Thanks for pointing this out! I've fixed this in the 1.4.2 release!

The try..catch wasn't needed anymore, polymorphic supported the new import quite a long time already.

@vdboor vdboor closed this Nov 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants