Skip to content

Conversation

bashu
Copy link
Contributor

@bashu bashu commented Jan 12, 2018

better exception handling, ref django-fluent/django-fluent-pages#132

@codecov
Copy link

codecov bot commented Jan 12, 2018

Codecov Report

Merging #66 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #66   +/-   ##
=======================================
  Coverage   64.98%   64.98%           
=======================================
  Files          12       12           
  Lines         794      794           
=======================================
  Hits          516      516           
  Misses        278      278
Impacted Files Coverage Δ
polymorphic_tree/models.py 63.79% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 736a804...dd10473. Read the comment docs.

@vdboor
Copy link
Member

vdboor commented Jan 15, 2018

I think this code should handle can_have_children instead. The reason it crashes in fluent-pages, is because the TextFile has can_have_children=False and this code looks for the child-types for a node that can't have children.

@bashu
Copy link
Contributor Author

bashu commented Jan 16, 2018

@vdboor I agree, but when we can see minor bugfix release?

@vdboor vdboor closed this in 73a11fa Jan 22, 2018
@vdboor
Copy link
Member

vdboor commented Jan 22, 2018

@bashu v1.5 is out, with Django 2.0 support too!

I noticed that 1.4.2 accidentally dropped support for older Django versions (1.6, 1,7, 1.9). I didn't notice that commit when I released a fix for django-polymorphic 2.0. Maybe that also caused your compatibility errors with polymorphic vs fluent-pages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants