Skip to content

Update version to 1.0.0 #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 40 commits into from
May 12, 2021
Merged

Update version to 1.0.0 #269

merged 40 commits into from
May 12, 2021

Conversation

rvlb
Copy link
Contributor

@rvlb rvlb commented May 6, 2021 •
edited
Loading

Closes #207
Closes #212
Closes #215
Closes #253

@rvlb rvlb requested a review from fjsj May 6, 2021 13:57
fjsj
fjsj requested changes May 6, 2021
View reviewed changes
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvlb please check the issues on milestone 1.0.0: https://github.com/django-webpack/django-webpack-loader/milestone/1

@rvlb rvlb requested a review from fjsj May 12, 2021 12:21
fjsj
fjsj reviewed May 12, 2021
View reviewed changes
fjsj
fjsj reviewed May 12, 2021
View reviewed changes
fjsj
fjsj requested changes May 12, 2021
View reviewed changes
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking nice. Some corrections TODO:

  • We should add db.sqlite3 to .gitignore. This PR is adding examples/simple/db.sqlite3.
  • Check inline comments.

fjsj
fjsj reviewed May 12, 2021
View reviewed changes
@fjsj fjsj mentioned this pull request May 12, 2021
Closed
@rvlb rvlb requested a review from fjsj May 12, 2021 19:19
fjsj
fjsj approved these changes May 12, 2021
View reviewed changes
Copy link
Member

@fjsj fjsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@rvlb rvlb merged commit 0e519d1 into master May 12, 2021
@gilmrjc gilmrjc mentioned this pull request May 12, 2021
Closed
@fjsj fjsj deleted the 1.0.0-release branch December 24, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjsj fjsj fjsj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

What's the status of this repo? 1.0.0 Package Needs Updates Invalid relative path concatenation in get_chunk_url
2 participants
@rvlb @fjsj