Add a setting to configure skip common chunks behaviour globally #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks. Please feel free to add this global setting behavior with tests too. Please test if the skip_common_chunks arg properly overrides the settings in all cases. |
|
Ok, that sounds great, I will put something together! |
hyshka
force-pushed
the
add-skip-common-chunks-setting
branch
from
7b4292c to
4aa0ee3
Compare
hyshka
changed the title
|
@fjsj I've reworked this PR, let me know what you think of this approach. |
You can now specify a 'SKIP_COMMON_CHUNKS' setting globally for each Webpack configuration. This will perform the same 'skip_common_chunks' logic from the 'render_bundle' template tag without having to add a parameter to every tag. To maintain backwards compatibility we default to 'False' and allow common chunks to be rendered to the HTML document as script tags. In the future, it will be easy to change this default behaviour if desired. I've added test coverage to ensure that the global setting can be override by the existing template tag parameter and that we maintain backwards compatibility.
hyshka
force-pushed
the
add-skip-common-chunks-setting
branch
from
56aa00f to
7498eb6
Compare
|
@fjsj Just wanted to bump this since it's been a couple of weeks. |
|
Thanks, I'll be checking this in the next couple of days. |
rvlb
approved these changes
Jun 20, 2022
|
Released on 1.6.0. Thanks! |
|
Thanks so much @fjsj! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is untested code but I am wondering if there is an appetite for a feature like this which would allow you to setskip_common_chunksper config without having to addskip_common_chunks=Trueto all of yourrender_bundletemplate tags. I realize this is likely an edge case but it would be helpful to have it as a setting instead of solely a template tag option.You can now specify a
SKIP_COMMON_CHUNKSsetting globally for each Webpack configuration. This will perform the sameskip_common_chunkslogic from therender_bundletemplate tag without having to add a parameter to every tag.To maintain backwards compatibility we default to 'False' and allow common chunks to be rendered to the HTML document as script tags. In the future, it will be easy to change this default behaviour if desired.
I've added test coverage to ensure that the global setting can be overridden by the existing template tag parameter and that we maintain backward compatibility.