Handle Redis response errors instead of silencing them #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception handling for send() silenced all Redis errors apart from the "full" message. This commit updates the exception logic to also specifically handle the "unknown command" error which might point at an unsupported version of Redis. It also now lets any other exception bubble up instead of being silently dropped. Reported by @wynbennet in #14.
I found no reference of supported versions of our dependencies, so I made wild guesses as to what might be supported.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exception handling for send() silenced all Redis errors apart from the
"full" message. This commit updates the exception logic to also
specifically handle the "unknown command" error which might point at an
unsupported version of Redis. It also now lets any other exception bubble
up instead of being silently dropped.
Reported by @wynbennett in #14.
I also added a wild guess as to what versions asgi_redis might support. I'm happy to also add Travis support for the whole grid of supported Django, Python and Travis versions if @andrewgodwin thinks it's a good idea.