Properly closed database connections #176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eb16ed0 removed (among a lot of other things) a call to close_old_connections(), mostly because I hadn't understood what that was doing exactly. Since then I've been kept awake at night with the sense of dread that old database connections were piling up unclosed on Django's server. So I wrote this wsgi middleware that should hopefully restore balance in the universe, or at least close db connections.
Comment on lines
+4
to
+22
| class DjangoDBManagementMiddleware: | ||
| """ | ||
| A simple WSGI middleware that manually manages opening/closing db connections. | ||
|
|
||
| Django normally does that as part of its own middleware chain, but we're using Trac's middleware | ||
| so we must do this by hand. | ||
| This hopefully prevents open connections from piling up. | ||
| """ | ||
|
|
||
| def __init__(self, application): | ||
| self.application = application | ||
|
|
||
| def __call__(self, environ, start_response): | ||
| request_started.send(sender=self.__class__) | ||
| try: | ||
| for data in self.application(environ, start_response): | ||
| yield data | ||
| finally: | ||
| request_finished.send(sender=self.__class__) |
There was a problem hiding this comment.
I think this would make a lovely talk.
|
Deployed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eb16ed0 removed (among a lot of other things) a call to close_old_connections(), mostly because I hadn't understood what that was doing exactly.
Since then I've been kept awake at night with the sense of dread that old database connections were piling up unclosed on Django's server.
So I wrote this wsgi middleware that should hopefully restore balance in the universe, or at least close db connections.