-
-
Notifications
You must be signed in to change notification settings - Fork 33.1k
Fixed #31118 -- Made FileInput to avoid the required attribute when initial data exists. #12276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Documentation changes and tests are required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ShubhamSingh20 Thanks 👍 I left comments.
Changes are missing in the Widget.use_required_attribute() docs, e.g.
otherwise. Special cases are :class:`~django.forms.ClearableFileInput`,
and :class:`~django.forms.FileInput` which return `False` ...
also versionchanged
annotation is missing.
Please remove ClearableFileInput.use_required_attribute()
it's not necessary anymore, because ClearableFileInput
inherits from FileInput
.
Should the |
No, 3.1. |
okay. I will change it accordingly |
…nitial data exists.
@ShubhamSingh20 Thanks 👍 I pushed minor edits to tests and docs, and added release notes. |
@felixxm Thanks 👍. For helping out. |
Added
use_required_attribute()
method toFileInput
widget, this will remove the required attribute if initial data is provided to theFileField
.