Skip to content

Fixed #31277 -- Relaxed system check of m2m intermediary tables for db_table collision when database routers are installed. #12461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fixed #31277 -- Relaxed system check of m2m intermediary tables for db_table collision when database routers are installed. #12461

wants to merge 1 commit into from

Conversation

Qu4tro
Copy link
Contributor

@Qu4tro Qu4tro commented Feb 16, 2020

@felixxm felixxm changed the title Fixed #31277 -- Relaxed system check on fields intermediary tables for db_table collision when database routers are installed by turning the error into a warning. Fixed #31277 -- Relaxed system check of m2m intermediary tables for db_table collision when database routers are installed by turning the error into a warning. Feb 17, 2020
@felixxm felixxm changed the title Fixed #31277 -- Relaxed system check of m2m intermediary tables for db_table collision when database routers are installed by turning the error into a warning. Fixed #31277 -- Relaxed system check of m2m intermediary tables for db_table collision when database routers are installed. Feb 17, 2020
felixxm
felixxm reviewed Feb 17, 2020
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Qu4tro Thanks for this patch 👍 I left comments.

@Qu4tro
Copy link
Contributor Author

Qu4tro commented Feb 17, 2020

Glad to help :D And thanks for the review.

Resolved most of the notes. The clashing_pair one is still unresolved, because I'm not sure on how to handle it.

Feedback on how to proceed would be great.

@Qu4tro
Copy link
Contributor Author

Qu4tro commented Feb 17, 2020

Okay, all resolved. Have also squashed the commits and changed the commit message to reflect the changes in the PR title.

Let me know if there's any other changes required for this PR to move forward.

@felixxm
Copy link
Member

felixxm commented Feb 17, 2020

@Qu4tro Thanks 👍 Welcome aboard ⛵

I pushed minor edits to tests and updated the hint ("Verify that the table of ...") to reuse clashing_obj.

@Qu4tro
Copy link
Contributor Author

Qu4tro commented Feb 17, 2020

Thanks!

Yeah, I diffed with my local changes and it looks great. Much appreciated!

@Qu4tro @felixxm
Fixed #31277 -- Relaxed system check of m2m intermediary tables for d…
288ac2a 
…b_table collision when database routers are installed.

Turned the error into a warning when database routers are installed.
@felixxm felixxm self-assigned this Feb 17, 2020
@felixxm
Copy link
Member

felixxm commented Feb 17, 2020

Merged in 8690878.

@felixxm felixxm closed this Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felixxm felixxm felixxm left review comments

Assignees

@felixxm felixxm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Qu4tro @felixxm