Fixed #31311 -- Removed unneeded escapes in validator regexes. #12498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@felixxm Can you just double-check for me. Thanks! |
carltongibson
changed the title
|
Hi @kimbo — just for bonus points, do you fancy adjusting the commit message to match the guidelines? (Past tense, with the |
kimbo
force-pushed
the
kl/cleanup-validator-re
branch
from
c75a90e to
de9df5b
Compare
|
@carltongibson How's that? |
Special characters lose their special meaning inside sets of characters. "-" lose its special meaning if it's placed as the first or last character.
felixxm
force-pushed
the
kl/cleanup-validator-re
branch
from
de9df5b to
7c6b663
Compare
felixxm
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.