Refs #31493 -- Replaced var with const/let in documentation JS. #12776
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jdufresne you may be interested to check |
jdufresne
approved these changes
Apr 22, 2020
docs/topics/i18n/translation.txt
Outdated
There was a problem hiding this comment.
Should s also be declared? I realize it was not before, so I don't know if it is deliberate or not.
There was a problem hiding this comment.
Good point, I think it should be.
adamchainz
force-pushed
the
ticket_31493_docs
branch
from
388345c to
2b09e31
Compare
carltongibson
approved these changes
Jun 24, 2020
carltongibson
force-pushed
the
ticket_31493_docs
branch
from
2b09e31 to
774ee42
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ticket
Pairs with #12767.