Fixed #31523 -- Removed jQuery dependency from actions.js. #12820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This more or less amounts to a rewrite of |
jdufresne
commented
Apr 29, 2020
|
buildbot, test on selenium. |
|
I'd like to take #12819 before this. |
|
Hey @jdufresne. If you could rebase, I shall take it on after the weekend. Thanks! |
|
Rebased 🙂 |
carltongibson
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
Hey @jdufresne. I have to say, this is lovely. Thanks, so much for the effort: a really nice modernisation.
(Sorry for the pause in review: it got bumped and then I needed an hour or two to sit down with it.)
I'll rebase now. +1.
|
buildbot, test on selenium. |
|
CI failure is unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://code.djangoproject.com/ticket/31523